feat: implement net.cidr_expand builtin - #525
Merged
Anand Krishnamoorthi (anakrish) merged 1 commit intoDec 17, 2025
Merged
Conversation
Signed-off-by: tjons <tylerschade99@gmail.com>
net.cidr_expand builtin
Collaborator
|
Tyler Schade (@tjons) I haven't seen those errors. Let me check. |
Collaborator
|
Hey Tyler Schade (@tjons), I am not able to reproduce those clippy errors. Which toolchain are you on? |
net.cidr_expand builtinnet.cidr_expand builtin
Contributor
Author
|
Anand Krishnamoorthi (@anakrish) those were on |
Anand Krishnamoorthi (anakrish)
approved these changes
Dec 17, 2025
Anand Krishnamoorthi (anakrish)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Thanks, Tyler Schade (@tjons)
Anand Krishnamoorthi (anakrish)
merged commit Dec 17, 2025
8b84d4c
into
microsoft:main
41 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
net.cidr_expandfrom #96.Anand Krishnamoorthi (@anakrish) the rvm implementation seems to have caused some issues with clippy checking lifetimes during precommit hooks:
is this expected?